Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Compare images #5

Merged
merged 6 commits into from
Aug 17, 2016
Merged

Compare images #5

merged 6 commits into from
Aug 17, 2016

Conversation

jml
Copy link
Contributor

@jml jml commented Aug 15, 2016

Adds a new compare-images command:

$ ./compare-images ../service-conf/k8s/dev/ ../service-conf/k8s/prod/
Image                          dev                   prod
-----------------------------  --------------------  --------------------
quay.io/weaveworks/grafana     master-0fc7cc2        master-08fd09d
quay.io/weaveworks/prometheus  master-0fc7cc2        master-4fb2aed
quay.io/weaveworks/ui-server   master-2899c36        master-45d67b3
tomwilkie/prometheus           frankenstein-8a5ec1b  frankenstein-ebe5808
weaveworks/scope               master-1a1021c        master-14d0e4e

Also:

  • creates a new package called kubedifflib
  • moves most of kubediff into there:
    • the diffing bits are in _diff
    • the common kubernetes stuff in _kube
  • updates KubeObject to use attrs

This change is Reviewable

@@ -28,6 +28,10 @@ For example:
Checking Secret 'kubediff-secret'
Checking Service 'kubediff'

Make sure the dependencies are installed first:

$ pip install -r requirements.txt

This comment was marked as abuse.

@tomwilkie
Copy link
Contributor

Couple of questions / nits, but LGTM otherwise.

@jml
Copy link
Contributor Author

jml commented Aug 16, 2016

PTAL.

@jml jml merged commit 0dae3fd into master Aug 17, 2016
@jml jml deleted the compare-images branch August 17, 2016 11:18
tomwilkie added a commit that referenced this pull request Oct 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants