Update helm chart README using Make #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, it's possible that the helm chart documentation contains the `image tag` version which might not be equal to the version in the helm chart, as it's only an example. This is a confusing, so instead we should use make to edit the application version everywhere. This fixes it by updating the Makefile to modify text of the chart's README using a regex looking for something similar to a version; then I used the updated makefile to edit the README, which in turns requires a bump of the version of the chart itself.
evrardjp
force-pushed
the
fix-make-helm-chart
branch
from
9a49d9d
to
0640683
Compare
dholbach
approved these changes
Jan 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it's possible that the helm chart documentation
contains the
image tagversion which might not be equal tothe version in the helm chart, as it's only an example.
This is a confusing, so instead we should use make to edit the
application version everywhere.
This fixes it by updating the Makefile to modify text of the
chart's README using a regex looking for something similar to
a version; then I used the updated makefile to edit the README.