Change helm chart default value for updateStrategy to RollingUpdate #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoeld
changed the title
|
Thank you for taking initiative and following up on my drive-by report! |
ckotzbauer
requested changes
Aug 5, 2021
There was a problem hiding this comment.
Thanks for your PR @dhoeld!
Could you please also change the value in the README of the chart? Then this should be ready to merge.
Incrementally update Pods by default when changing the DaemonSet spec. Fixes #413
ckotzbauer
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets the default value for the DaemonSet updateStrategy to RollingUpdate to automatically update kured Pods on every change of the DaemonSet spec.
Fixes #413