Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Local Networks" is confusing #2748

Closed
bboreham opened this issue Jul 25, 2017 · 4 comments
Closed

"Local Networks" is confusing #2748

bboreham opened this issue Jul 25, 2017 · 4 comments
Assignees
@rade
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality
Milestone
Next

Comments

@bboreham
Copy link
Collaborator

I don't really know what it is supposed to be, but maybe strip out the /32 entries because they are not "networks"?

image
@rade rade added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Jul 25, 2017
@rade
Copy link
Member

rade commented Jul 25, 2017

The /32 are there because of an evil hack to do with k8s services.

@2opremio
Copy link
Contributor

2opremio commented Jul 25, 2017 •
edited by rade

These are the K8s services. There wasn't a clean way to add them cleanly because k8s doesn't expose the service network CIDR. kubernetes/kubernetes#25533

@bboreham
Copy link
Collaborator Author

But why are you showing them to the user on that screen? What is she supposed to do with them?

@rade rade added this to the Next milestone Jul 31, 2017
@rade
Copy link
Member

rade commented Jul 31, 2017

Why are we showing "Local Networks" at all?

Currently this contains

  • the networks of host interfaces
  • the IPAM ranges of docker networks
  • the Weave Net IPAM default subnet
  • all k8s service IPs

@rade rade self-assigned this Jul 31, 2017
rade added a commit that referenced this issue Jul 31, 2017
@rade
synthesise k8s service network from service IPs
8a7370d 
This prevents cluttering host.LocalNetworks with lots of /32
addresses. These were unsightly and rather distracting in the UI. They
also bloated the report and slowed down server-side rendering.

Fixes #2748.
@rade rade mentioned this issue Jul 31, 2017
Merged
rade added a commit that referenced this issue Aug 1, 2017
@rade
synthesise k8s service network from service IPs
12add72 
This prevents cluttering host.LocalNetworks with lots of /32
addresses. These were unsightly and rather distracting in the UI. They
also bloated the report and slowed down server-side rendering.

Fixes #2748.
rade added a commit that referenced this issue Aug 1, 2017
@rade
synthesise k8s service network from service IPs
4dae7ed 
This prevents cluttering host.LocalNetworks with lots of /32
addresses. These were unsightly and rather distracting in the UI. They
also bloated the report and slowed down server-side rendering.

Fixes #2748.
@rade rade closed this as completed in #2779 Aug 1, 2017
rade added a commit that referenced this issue Aug 1, 2017
@rade
Merge pull request #2779 from weaveworks/2748-synthesise-service-network
1e38e78 
synthesise k8s service network from service IPs

Fixes #2748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rade rade

Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality
Projects
None yet
Milestone
Next
Development

No branches or pull requests
3 participants
@rade @2opremio @bboreham