Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move grouping by name, DNS name, image to Filters section #3625

Open
bia opened this issue May 27, 2019 · 4 comments
Open

Move grouping by name, DNS name, image to Filters section #3625

bia opened this issue May 27, 2019 · 4 comments
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer needs-design UI representation/flow requires a fair amount of thought

Comments

@bia
Copy link
Contributor

bia commented May 27, 2019

Related to #3547,
Semantically, these groupings are more like filters than their own topological categories.

Screenshot 2019-05-27 at 12 02 58

@bia bia added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label May 27, 2019
@rade
Copy link
Member

rade commented May 27, 2019

Quite the opposite is the case. Groupings are more like topological categories than filters. Filtering does not change the kind of thing being shown, e.g. showing only 'application containers' shows a subset of all containers. By contrast, showing containers 'by image' shows images, not containers.

@fbarl fbarl added the needs-design UI representation/flow requires a fair amount of thought label May 27, 2019
@bia
Copy link
Contributor Author

bia commented May 27, 2019

Indeed. This was formulated improperly.
I meant to point out that 'groupings' at the very least read like something different to the topologies themselves and that grouping controls could be pulled out of these columns.
The bottom left Filter corner is already prone to becoming impossibly crowded. We could find another place for it here-ish?

190527scope-grouping-5

Another (potentially too confusing) option would be to rename by image to Images
cc @fbarl

@rade
Copy link
Member

rade commented May 28, 2019

We could simply ditch the grouping topologies. I don't think they are all that useful, especially not in a k8s context.

@bia
Copy link
Contributor Author

bia commented Jun 3, 2019

Talked with @fbarl and we decided to add dropdown options embedded into the topology selection.

190603scope-grouping-1

You can view the available groupings on click
190603scope-grouping-2

and click again select one
190603scope-grouping-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer needs-design UI representation/flow requires a fair amount of thought
Projects
None yet
Development

No branches or pull requests

3 participants