Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launcher script: Fix inconsistent whitespace #1776

Merged
merged 1 commit into from Aug 9, 2016

Conversation

ekimekim
Copy link
Contributor

@ekimekim ekimekim commented Aug 9, 2016

Spotted this while reading through some bits and pieces for understanding.

@jml
Copy link
Contributor

jml commented Aug 9, 2016

LGTM.

Please merge after tests pass.

@ekimekim ekimekim merged commit d0f0e8d into master Aug 9, 2016
@ekimekim ekimekim deleted the mike/launcher/fix-whitespace branch August 9, 2016 19:18
@tomwilkie
Copy link
Contributor

@ekimekim would be good to make the linter script catch this in the future.

@jml
Copy link
Contributor

jml commented Aug 10, 2016

And also to have the linter actually run on scope shellscript code :)

@ekimekim
Copy link
Contributor Author

+1, will do. good exercise to understand our linting, and to a lesser
extent our CI

On 10 August 2016 at 02:58, Jonathan Lange notifications@github.com wrote:

And also to have the linter actually run on scope shellscript code :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1776 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiyxI185xE4PWV5LcT0M_EvgYvbiE65ks5qeaDagaJpZM4JgWl4
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants