Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes services the initial topology if available #1823

Merged
merged 2 commits into from Sep 1, 2016

Conversation

foot
Copy link
Contributor

@foot foot commented Aug 23, 2016

  • Otherwise reverts to containers

Fixes #1809

@rade
Copy link
Member

rade commented Aug 23, 2016

Otherwise reverts to containers

The prioritisation should be services -> deployments -> replica sets -> pods -> containers. Says @tomwilkie.

@foot
Copy link
Contributor Author

foot commented Aug 23, 2016

Cool, will update

//
// top priority first
//
const TOPOLOGY_DISPLAY_PRIORITY = [

This comment was marked as abuse.

@davkal
Copy link
Contributor

davkal commented Aug 24, 2016

Code looks good.

Implementation-nit: priority should be driven by backend, so that when new topos are added, UI does not have to be involved.

UX-nit: If Services is the most important one, it should be at the top. Any introduction of priority ordering trumps representation model ordering (lower topos are groupings of higher topos). This needs to be changed in the backend.

@davkal
Copy link
Contributor

davkal commented Aug 24, 2016

priority should be driven by backend, so that when new topos are added, UI does not have to be involved.

Actually, we should put this up for discussion in the next meeting.

@davkal davkal assigned foot and unassigned davkal Aug 24, 2016
@foot foot force-pushed the 1809-make-services-initial-topo branch from e7c062c to 143939a Compare August 29, 2016 12:15
@davkal
Copy link
Contributor

davkal commented Aug 29, 2016

Can't we make service the main topo?

screen shot 2016-08-29 at 16 31 26

@davkal
Copy link
Contributor

davkal commented Aug 29, 2016

If we cant completely flip the order, I'd say let's stick to the original one.

@foot
Copy link
Contributor Author

foot commented Aug 29, 2016

Node type, followed by its aggregates in order of most interest breaks strict "spatial alignment" w/ the priorities we've set up but I think it still works. If no aggs fall back to basic type.

@davkal
Copy link
Contributor

davkal commented Aug 29, 2016

I mostly have a problem with a sub-menu entry being the most important one (decided by priority). I feel that it makes the menu harder to grok.
An alternative would be dynamic prio ordering in the backend, so that the default one is the top one.

- Otherwise reverts to containers
- Show something from k8s by default if its around.
@foot foot force-pushed the 1809-make-services-initial-topo branch 2 times, most recently from 47138a1 to 343a986 Compare September 1, 2016 14:04
@foot foot merged commit 574deee into master Sep 1, 2016
@foot foot deleted the 1809-make-services-initial-topo branch September 22, 2016 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants