Check existence of SHA1 before running git diff
#1924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
reviewed
Oct 14, 2016
| # it could be it isn't, e.g. after a force push | ||
| commit_valid() { | ||
| local rev=$1 | ||
| git rev-parse --quiet --verify "$rev^{commit}" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| cached_revision=$(cached_image_rev) | ||
| if [ -z "$cached_revision" ]; then | ||
| echo ">>> No cached image found; rebuilding" | ||
| rebuild | ||
| exit 0 | ||
| fi | ||
|
|
||
| if ! commit_valid "$cached_revision"; then | ||
| echo ">>> cached SHA1 not found in repo, rebuilding" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Can you file this against build-tools.git pls? Then update the subtree in here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug whereby a cached Docker image would always end up being used, if the git commit it was built from was not reachable anymore.