Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help panel fields max height #2353

Merged
merged 1 commit into from Mar 22, 2017
Merged

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Mar 20, 2017

Fixes #2352.

@fbarl fbarl self-assigned this Mar 20, 2017
@fbarl fbarl requested a review from davkal March 20, 2017 13:48
Copy link
Contributor

@davkal davkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's very hard to tell that there are more then there visible now:

screen shot 2017-03-22 at 10 58 35

Any idea how we could make that more obvious?

@fbarl fbarl force-pushed the help-panel-fix-height-overflow branch from 4d22855 to a940064 Compare March 22, 2017 10:54
@fbarl
Copy link
Contributor Author

fbarl commented Mar 22, 2017

Eh, iMachines and scrollbars :/ We currently have the overflow setting at auto, which works as it should both on my Chrome and Firefox. I talked to @foot about it and apparently there is a setting you can change to always show scrollbars (http://osxdaily.com/2011/08/03/show-scroll-bars-mac-os-x-lion/). I assume you have it off, because scrollbars were displayed nicely on Simon's mac.

Three ideas that wouldn't require OS X users to change their settings:

  1. Setting overflow-y: scroll might force the scrollbars visibility, but honestly it looks very bad on my Chrome when there's no overflow.
  2. Doing some quick CSS magic (hopefully without Javascript), to somehow signify when there is more content below or above (e.g. white shadows) that would work on all platforms. Then, if we would want a consistent UI, it would be good to hide the existing scrollbars on Chrome, but that seems hacky too.
  3. Using an external library or our own component for scrolling - seems like an overkill for this issue.

@davkal All in all, I'd prefer to just merge it as it is (after you confirm it works well by turning on the scrollbar settings on your machine), but I'd also be willing to consider 2 and 3, although perhaps in a separate story?

@davkal
Copy link
Contributor

davkal commented Mar 22, 2017

I'd prefer a show-more link, that visibly expands the container, somehow carries a number of entries, and thereby makes it easy to deduce how many items one should see (or scroll through). But yeah, different story.

@fbarl fbarl merged commit 53212d2 into master Mar 22, 2017
@fbarl fbarl deleted the help-panel-fix-height-overflow branch March 24, 2017 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants