Add a test that checks if reports with data round-trip #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bboreham Mind fixing the linting error? |
|
I re-did the |
|
@bboreham Mind fixing the linter errors? |
|
@bboreham IIRC you felt that the I don't really want this PR to sit around here forever. So please make a call whether to proceed or close. |
|
No, I didn't say that. Have rebased and removed the "tests which check backwards compatibility: for instance that the binary data encoded by version 1.2 still decodes to the expected structure", which was too ugly. |
Merged
Previously the only roundtrip test was for an empty report. This test has fake data similar to that found in real reports. 'Metrics' does not round-trip exactly, so a DeepEqual workaround is added for that.
bboreham
force-pushed
the
big-roundtrip
branch
from
5092cc0
to
f44f880
Compare
|
I would like this test to be added. Have rebased on latest master. |
rade
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the only roundtrip test was for an empty report. This test has fake data similar to that found in real reports.
Node.Metricsdoes not round-trip exactly: it is tagged withomitemptyso when decoded an empty map turns into the zero value. ADeepEqualworkaround is added so the test passes.Perhaps it would be better to adjust the decode so the field is not nil after decoding.
This PR is a precursor to tests which check backwards compatibility: for instance that the binary data encoded by version 1.2 still decodes to the expected structure.