Update github.com/weaveworks/common & dependencies (needs go1.8) #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndstr
force-pushed
the
update-weaveworks-common
branch
2 times, most recently
from
f7b7d72
to
1b56c9c
Compare
rndstr
changed the title
Closed
|
Failing in CI with |
Bumped all packages that make the build fail:
gvt update github.com/golang/protobuf/proto
gvt fetch github.com/golang/protobuf/ptypes
gvt fetch google.golang.org/genproto/googleapis/rpc/status
gvt update google.golang.org/grpc/status
gvt update google.golang.org/grpc/transport
gvt update golang.org/x/net/http2
rndstr
force-pushed
the
update-weaveworks-common
branch
from
1b56c9c
to
c817ecc
Compare
|
rebased master (with go1.8) |
2opremio
approved these changes
Jun 26, 2017
|
@rndstr ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces weaveworks/common#42
Bumped all packages that make the build fail:
Latest weaveworks/common only compiles on go1.8, scope uses go1.7 right now.