Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents 6 digit pids from being truncated in details panel/table mode #2666

Merged
merged 2 commits into from Jul 5, 2017
Merged

Prevents 6 digit pids from being truncated in details panel/table mode #2666

merged 2 commits into from Jul 5, 2017

Conversation

foot
Copy link
Contributor

@foot foot commented Jun 29, 2017

Fixes #2660

@foot foot requested a review from fbarl June 29, 2017 13:29
rndstr
rndstr approved these changes Jun 29, 2017
View reviewed changes
Copy link
Contributor

@rndstr rndstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tested in chrome and all digits seem to fit ✌️)

fbarl
fbarl suggested changes Jun 30, 2017
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to be enough for Firefox though, 56px seems to do it on my computer, maybe make it 57px to be on a safe side? :D

@foot
Copy link
Contributor Author

foot commented Jul 3, 2017

Thanks @fbarl! I think it might be linux too _.

56 it is.

@foot foot force-pushed the 2660-fix-pid-truncation branch from b4a6436 to 0e3e6fe Compare July 3, 2017 09:10
@rndstr
Copy link
Contributor

rndstr commented Jul 3, 2017

FWIW removing the truncate would also make sure it never cuts it off but just mis-align it in case it doesn't fit. Haven't looked closely at the code, might be more work than anticipated to selectively remove truncate from columns. (my test was on Linux btw)

@foot foot force-pushed the 2660-fix-pid-truncation branch from 0e3e6fe to ba29271 Compare July 4, 2017 08:42
@foot foot merged commit 77ba8aa into master Jul 5, 2017
@foot foot deleted the 2660-fix-pid-truncation branch July 5, 2017 12:27
@foot
Copy link
Contributor Author

foot commented Jul 5, 2017

@rndstr Thats an interesting thought actually, will have a think.

The ... is a nice "fail fast" soln which kinda highlights something's wrong with our width expectations too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndstr rndstr rndstr approved these changes

@fbarl fbarl fbarl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@foot @rndstr @fbarl