Don't return blank addresses for pods #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
approved these changes
May 29, 2018
|
@bboreham we now have a commit format policy borrowed from CNI, can you please try to comply with it? https://github.com/weaveworks/scope/blob/master/CONTRIBUTING.md#format-of-the-commit-message We can discuss whether that's valuable or not. I think it's good to have some consistency. |
A small performance improvement - instead of creating an entry in a map which doesn't match anything, just skip a pod with a blank IP.
bboreham
force-pushed
the
dont-map-pod-blank-ip
branch
from
5f1b48a
to
fe28feb
Compare
|
@2opremio amended the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small performance improvement - instead of creating an entry in a map which doesn't match anything, just skip a pod with a blank IP.
This was sitting as part of #3089 which we're not going to merge.