Disable CRI probe by default #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was enabled by default but we want it to be disabled instead, just like with the docker probe.
|
CI failed on flake #3209 - I hit the re-run button |
bboreham
approved these changes
Aug 8, 2018
|
Should we write some code to try to figure out which type of container runtime is in use, without configuration flags? |
Problem is we need to also mount the container runtime endpoint socket/volument in the deployment manifest file anyways when deploying scope so the user needs to know which endpoint to use before starting scope anyways. We do that in the launcher for the weave cloud scope deployment -> weaveworks/launcher#252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was enabled by default but we want it to be disabled instead, just
like with the docker probe.