Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI toolchain dir permissions error #3382

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Fix UI toolchain dir permissions error #3382

merged 1 commit into from
Oct 11, 2018

Conversation

leth
Copy link
Contributor

@leth leth commented Oct 10, 2018

Create the UI toolchain dir from the Makefile to prevent docker from creating it with root as the owner

@leth leth requested a review from dholbach October 10, 2018 14:58
@leth leth changed the title Create UI toolchain dir from Makefile Fix UI toolchain dir permissions error Oct 10, 2018
@bboreham
Copy link
Collaborator

I had to chown two directories:

.cache/build_node_modules/
client/node_modules/

so is this one change enough?

@dholbach
Copy link
Contributor

Yes, I'm seeing the same problem as Bryan.

@leth
Copy link
Contributor Author

leth commented Oct 11, 2018

Ah yes, the extra one is also created by docker, thanks!

To prevent docker from creating it with root as the owner
Copy link
Contributor

@dholbach dholbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the build issue for me. Thanks @leth!

@leth leth merged commit 9b31c85 into master Oct 11, 2018
@leth leth deleted the fix-dir-owner-root branch October 11, 2018 12:51
@bboreham
Copy link
Collaborator

I tried this and it still didn't work. There are two directories and only one change to the makefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants