Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: update stopped container message #3396

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

ltachet
Copy link
Contributor

@ltachet ltachet commented Oct 18, 2018

The message is now more friendly as requested!

Fixes #2879

@satyamz
Copy link
Contributor

satyamz commented Oct 19, 2018

Hi @ltachet ! Thanks for the PR. Can you attach a screenshot if its available?

@satyamz satyamz requested a review from fbarl October 19, 2018 18:13
@ltachet
Copy link
Contributor Author

ltachet commented Oct 20, 2018

Hi @satyamz ! Here is the screenshot of the container's view:

scope_container_rm

@satyamz
Copy link
Contributor

satyamz commented Oct 21, 2018

Hi @ltachet Thanks! Rest looks good to me.

@bboreham Are you okay with this message? Please run the IT once for this PR.

@fbarl
Copy link
Contributor

fbarl commented Oct 22, 2018

I'll let @bboreham decide on this one, as I'm not a native speaker :)

@fbarl fbarl requested review from bboreham and fbarl and removed request for fbarl October 22, 2018 08:12
@dholbach
Copy link
Contributor

Most of the messages suggested by Bryan were just up for laughs.

I'm also not a native-speaker, but "passed on" is not necessarily jargon which translates to

  • this container was stopped
  • we can't communicate with this container any more

To me "passing on" just describes that a human being died, so it's not as clear as it could be.

How about a simple "Container X not found." or "Can't connect to container X."? (... if the error message is JUST about containers.)

@ltachet
Copy link
Contributor Author

ltachet commented Oct 28, 2018

Hi @dholbach, I just updated the message by "X not found!". I think that this message is more explicit and will cover all cases :)

Copy link
Collaborator

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham bboreham merged commit 2e87b02 into weaveworks:master Oct 30, 2018
@ltachet ltachet deleted the dead-container-msg branch October 30, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants