Disable host and endpoint reporting in Kubernetes cluster mode #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the probe is run with --probe.kubernetes.role=cluster, disable host reporting and endpoint reporting since it duplicates what is being done by the per-host probe.
rade
approved these changes
Nov 5, 2018
| SpyProcs: flags.spyProcs, | ||
| UseConntrack: flags.useConntrack, | ||
| WalkProc: flags.procEnabled, | ||
| UseEbpfConn: flags.useEbpfConn, |
There was a problem hiding this comment.
Since this now only executes in the non-k8s-cluster-role case, you can get rid of the code that clears all these flags in
Line 115 in 71972c3
There was a problem hiding this comment.
Yeah, I thought it was better left as-is than to cherry-pick those that are used now. It’s clearer.
There was a problem hiding this comment.
but none of the flags set earlier on are used anymore, except for the two that are clearly kubernetes related, i.e.
flags.kubernetesKubeletPort = 0
flags.kubernetesEnabled = true
There was a problem hiding this comment.
I guess the fact that we are having this debate proves my point, but still, I see spyProcs cleared on line 118 and used on line 126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the probe is run with
--probe.kubernetes.role=cluster, disable host reporting and endpoint reporting since it duplicates what is being done by the per-host probe.This was missed from #3274