Add a check that the top-level UI is not empty #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
test-basic-ui
branch
2 times, most recently
from
163ebb2
to
c154ac1
Compare
|
Test failed as desired on bad build: https://circleci.com/gh/weaveworks/scope/10998 |
bboreham
force-pushed
the
test-basic-ui
branch
from
c154ac1
to
a32ebf2
Compare
|
Test succeeded after including the fix in #3439 https://circleci.com/gh/weaveworks/scope/11023 |
satyamz
approved these changes
Nov 27, 2018
qiell
approved these changes
Nov 27, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should detect the symptom at #3438