update xterm.js dependency (CVE-2019-0542)

[dholbach]

Updating xterm.js because of https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-0542

[dholbach]

Hum. This is probably not as straight-forward as I thought.

Now that I retried it in a local build and running scope launch, it works only the second time (clicking on host to start a shell there), the first time the screen is blank.

[dholbach]

Looks like my last comment is an unrelated problem which happens with xterm.js 3.3.0, 3.8.1 and 3.10.1. I'll file a separate issue for this.

[dholbach]

Tried it on minikube (built locally, pushed image to dockerhub, pointed k8s deployment to those images). The first launch of a shell in a container came up blank (as in #3559), this is with the current PR (using xterm.js 3.8.1). I can't say I'm confident in this change now.

Help wanted, setting back to WIP.

[foot]

Having a quick look...

[foot]

• Under firefox sometimes the first time you open a terminal it stays blank even after input.
• As noted this is not a regression and also happens on master

[dholbach]

Let's go with 3.10.1 then. It fixes a number of bugs and is faster. Originally I wanted to just update to the closest, unaffected version, but since the behaviour is the same between all versions, let's go with the most recent.