performance(aws_collector): don't persist shortcut reports #3716
Conversation
Shortcut reports are sent to update the UI quickly, on events like a container starting. We don't need to persist them in the time-travel data since the same information will be covered by a regular report a few seconds later.
There was a problem hiding this comment.
Does this change really gain much? After all, shortcut reports are very small.
I was wondering whether this make the UI less fluid when time-travelling, but then realised that, iirc, when time-travelling the short-cut reports will only reach the UI as part of the periodic UI update anyway, so a reduction in fluidity compared to live mode is already present in the current code. Correct? It might be worth elucidating that in a comment in the code or commit.
|
S3 charges per write (and read) as well as for monthly storage. Also DynamoDB writes require provisioning. I believe shortcut reports are sent immediately to the UI. |
Even when time-travelling? |
Sorry I didn't read that last bit. In time-travel mode, if you inch the time forward by one second you would be able to tell the difference. |
Shortcut reports are sent to update the UI quickly, on events like a container starting.
We don't need to persist them in the time-travel data since the same information will be covered by a regular report a few seconds later.