Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing for pipe operations; updates weaveworks, jaeger and aws dependencies #3745

Merged
merged 3 commits into from Feb 4, 2020
Merged

Add tracing for pipe operations; updates weaveworks, jaeger and aws dependencies #3745

merged 3 commits into from Feb 4, 2020

Conversation

bboreham
Copy link
Collaborator

@bboreham bboreham commented Jan 24, 2020 •
edited

Part of trying to track down #3684.

Need to update weaveworks/common to get a version of the tracer which works with websockets (weaveworks/common#173).

Add some spans for Consul operations related to pipes, which in turn need Context parameters piped through.

@bboreham bboreham merged commit 2c2671e into master Feb 4, 2020
@bboreham bboreham deleted the pipe-tracing branch February 4, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl Awaiting requested review from fbarl

@qiell qiell Awaiting requested review from qiell

@satyamz satyamz Awaiting requested review from satyamz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bboreham