Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate one-line-of-nodes layouts #679

Merged
merged 2 commits into from Nov 18, 2015
Merged

Mitigate one-line-of-nodes layouts #679

merged 2 commits into from Nov 18, 2015

Conversation

davkal
Copy link
Contributor

@davkal davkal commented Nov 13, 2015

Previously it looked like this:

screen shot 2015-11-17 at 15 14 10

To mitigate:

  • exclude 0-degree nodes from layout run
  • layout 0-degree nodes separately

With this PR it looks like this for the same report:

screen shot 2015-11-17 at 15 13 58

@davkal davkal changed the title [WIP] Mitigate one-line-of-nodes layouts Mitigate one-line-of-nodes layouts Nov 17, 2015
@davkal
Separate single nodes to render them differently
8691b04 
* Layout single nodes next to/below graph
* fixes #375
@peterbourgon
Copy link
Contributor

Ran it quickly on my box. No obvious problems. 👍

davkal added a commit that referenced this pull request Nov 18, 2015
@davkal
Merge pull request #679 from weaveworks/375-oneline
8a17ad4 
Mitigate one-line-of-nodes layouts
@davkal davkal merged commit 8a17ad4 into master Nov 18, 2015
@davkal davkal deleted the 375-oneline branch November 18, 2015 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davkal @peterbourgon