Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a spinner while node details are loading #691

Merged
merged 5 commits into from Nov 26, 2015
Merged

Conversation

davkal
Copy link
Contributor

@davkal davkal commented Nov 20, 2015

screen shot 2015-11-20 at 16 51 12

@2opremio
Copy link
Contributor

I am getting the spinner but the details pane color is not matching the node's color. Wasn't that fixed?

screen shot 2015-11-24 at 4 48 34 pm

Also, as you show in your screenshot, the details panel is grey while showing the spinner. Why aren't you showing the final color? Is there a technical limitation preventing you from doing that?

@davkal
Copy link
Contributor Author

davkal commented Nov 24, 2015

The color matching was done in a concurrent PR so it's broken in this one, but was now merged to master in #689 and #690.

But already coloring the panel in the final color is a good idea. will do that.

@2opremio
Copy link
Contributor

cool

@davkal
Copy link
Contributor Author

davkal commented Nov 24, 2015

@2opremio PTAL.

@2opremio
Copy link
Contributor

@davkal LGTM, however, I've noticed that if you click on nodes while they are in the background, their detail requests end up somehow queuing (?) and displaying when you are no longer interested.

http://g.recordit.co/mf8inTLSFB.gif

@davkal
Copy link
Contributor Author

davkal commented Nov 24, 2015

You are right, when clicked, the details panel should go back to Loading mode.

@2opremio
Copy link
Contributor

Will test this tomorrow. Why are tests failing BTW?

@2opremio
Copy link
Contributor

Edge test ...

@davkal
Copy link
Contributor Author

davkal commented Nov 24, 2015

yeah, unrelated.

@2opremio
Copy link
Contributor

It still suffers from the problem I mentioned, this video makes it more clear (wait until the end):

@davkal
Copy link
Contributor Author

davkal commented Nov 25, 2015

Ah now I know what u mean. Will see how/if this can be fixed.

@2opremio
Copy link
Contributor

Much better now, although the details pane takes longer to load (it could be that my system is slower today due to the number of containers) and the Internet node for some reason is brown while it loads (although it's final color is purple):

Wrong internet details pane color while loading

@2opremio
Copy link
Contributor

LGTM

davkal added a commit that referenced this pull request Nov 26, 2015
Show a spinner while node details are loading
@davkal davkal merged commit 385ba4b into master Nov 26, 2015
@davkal davkal deleted the loading-details branch November 26, 2015 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants