RED method graphs for Prism #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jml
force-pushed
the
904-red-prism-joke
branch
from
6618623
to
a9de8c1
Compare
|
@jml needs a rebase. Will review in the mean time. |
tomwilkie
reviewed
Oct 25, 2016
| histogram_quantile(0.95, sum(rate(scope_request_duration_seconds_bucket{ws="false",job="default/authfe",route!~"(admin|metrics).*"}[5m])) by (le, route)) | ||
| route:scope_authfe_request_duration_seconds:50quantile = | ||
| histogram_quantile(0.5, sum(rate(scope_request_duration_seconds_bucket{ws="false",job="default/authfe",route!~"(admin|metrics).*"}[5m])) by (le, route)) | ||
|
|
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
reviewed
Oct 25, 2016
| "targets": [ | ||
| { | ||
| "expr": "sum(irate(scope_request_duration_seconds_count{job=\"default/authfe\",status_code =~ \"1..\",route=~\"api_prom.*\"}[1m]))", | ||
| "intervalFactor": 2, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Pretty impossible to review this dashboards; we should start using jsonnet to generate them. Will file an issue for this. LGTM otherwise - one nit about one of the recording rules. |
jml
force-pushed
the
904-red-prism-joke
branch
from
bb3974a
to
b01ab40
Compare
jml
added a commit
that referenced
this pull request
Oct 25, 2016
jml
added a commit
that referenced
this pull request
Oct 25, 2016
Fix PromQL syntax error introduced by #949
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET) and write (anything else)Fixes #904.