Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: styled-components@3.4.10 #426

Merged
merged 1 commit into from
Nov 26, 2018
Merged

chore: styled-components@3.4.10 #426

merged 1 commit into from
Nov 26, 2018

Conversation

guyfedwards
Copy link
Contributor

related #370

Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 👍

One question though - why not upgrade to the latest version 4.1.1 while we're at it?

@@ -174,20 +174,20 @@ exports[`<Search /> snapshots renders a group of terms 1`] = `
}

.c0 .c5,
.c0 .Dropdown-sc-17i3rgt-5 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that losing the component names like that won't have any bad implications - it shouldn't though as far as I know :)

@guyfedwards
Copy link
Contributor Author

@fbarl Still waiting for types to arrive for v4 flow-typed/flow-typed#2933

I tried without success to get 4 working with the types in that PR but seems it is not yet complete.

Now the extends have been removed the upgrade from 3->4 should be quick.

@guyfedwards guyfedwards merged commit daef532 into master Nov 26, 2018
@guyfedwards guyfedwards deleted the styled-components-3 branch November 26, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants