Add check to download deps only once (#450)

* Add check to download deps only once * Run make clean in build step
weaveworks · Jul 12, 2021 · 8073c57 · 8073c57
1 parent 8815bcc
commit 8073c57
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 15 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -53,12 +53,10 @@ jobs:
         go-version: 1.16.x
     - name: Checkout code
       uses: actions/checkout@v2
-    - name: Install UI Deps
-      run: npm ci
-    - name: Build UI Assets
-      run: make cmd/ui/dist/index.html
+    - name: Clean
+      run: make clean
     - name: build
-      run: make
+      run: make wego
     - name: Store wego binaries
       uses: actions/upload-artifact@v2
       with:

diff --git a/.gitignore b/.gitignore
@@ -11,3 +11,4 @@ node_modules
 coverage
 *.lcov
 ginkgo.report
+.deps
diff --git a/Makefile b/Makefile
@@ -51,15 +51,19 @@ clean:
 	rm -rf cmd/ui/dist
 	rm -rf coverage
 	rm -rf node_modules
+	rm .deps
 # Run go fmt against code
 fmt:
 	go fmt ./...
 # Run go vet against code
 vet:
 	go vet ./...
 
-dependencies:
+.deps:
 	$(CURRENT_DIR)/tools/download-deps.sh $(CURRENT_DIR)/tools/dependencies.toml
+	@touch .deps
+
+dependencies: .deps
 
 node_modules:
 	npm install

diff --git a/package-lock.json b/package-lock.json