Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add app if config repo is public #1278

Closed
4 tasks
J-Thompson12 opened this issue Jan 6, 2022 · 2 comments · Fixed by #1301
Closed
4 tasks

Unable to add app if config repo is public #1278

J-Thompson12 opened this issue Jan 6, 2022 · 2 comments · Fixed by #1301
Assignees
Labels
bug Something isn't working severity/low low < medium < high < critical

Comments

@J-Thompson12
Copy link
Contributor

J-Thompson12 commented Jan 6, 2022

Describe the bug
Unable to add gitlab or github app if the config repo is public.
Error for public repo:

"error":"unable to clone 'ssh://git@gitlab.com/gogittest/sub-group/test-app-t75anmiy.git': ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey] │
│ , no supported methods remain"}  

Environment

  • gitops: [e.g. v0.1.0]
  • kubernetes: [e.g. 1.20.4]
    • KinD - version]
    • k3s - version
    • cloud [e.g., EKS, AKS] version
    • other - name version
  • Browser + version: [e.g. chrome 74, safari 12, firefox 87]

Affects versions

To Reproduce
Steps to reproduce the behavior:

  1. Start with fresh env
  2. Install gitops using public config repo
  3. Run gitops add app . --config-repo=<repo>
  4. See error

Expected behavior
The app to add and reconcile properly.

Additional context

@J-Thompson12 J-Thompson12 added bug Something isn't working severity/high low < medium < high < critical team/bluetonium labels Jan 6, 2022
@J-Thompson12 J-Thompson12 changed the title Unable to add gitlab app Unable to add app if config repo is public Jan 7, 2022
@J-Thompson12 J-Thompson12 removed their assignment Jan 7, 2022
@J-Thompson12 J-Thompson12 added severity/low low < medium < high < critical and removed severity/high low < medium < high < critical labels Jan 7, 2022
@J-Thompson12 J-Thompson12 self-assigned this Jan 10, 2022
@J-Thompson12
Copy link
Contributor Author

J-Thompson12 commented Jan 10, 2022

The changes made in #1249 made it so that without a deploy key we are unable to clone the repo. Install without auto-merge does not clone it just creates a PR and then add always clones so it fails. Install with auto-merge clones the repo so it fails to install.

@J-Thompson12
Copy link
Contributor Author

Possible solutions:

  1. Force users to use private repos for config repo
  2. Use go-git-providers for auto-merge to avoid cloning.
  3. Remove changes to only using deploy key on private.
  4. A solution I dont know of that magically fixes all our problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity/low low < medium < high < critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant