Avoid uploading key in public repos #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecordaz
approved these changes
Dec 21, 2021
|
|
||
| addCommand := "add app . --auto-merge=true" | ||
| configRepoURL := "ssh://git@gitlab.com/" + gitlabPublicGroup + "/" + configRepoName + ".git" |
There was a problem hiding this comment.
I would suggest to use fmt.Sprintf to build this string for readability
There was a problem hiding this comment.
I agree, but I decided t keep it this way because that's how URLs are being built across the whole acceptance suite, I'd rather keep consistency over something I prefer.
yep, they are there but didn't break because they use a private repo as config url |
jpellizzari
force-pushed
the
1111-public-repo
branch
from
bada709
to
1de2f76
Compare
jpellizzari
force-pushed
the
1111-public-repo
branch
from
1de2f76
to
dd99c8a
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1111
What changed?
Why?
How did you test it?
Release notes
Documentation Changes