-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitLab auth token retrieval to the UI #985
Comments
Testing in Chrome and Firefox. We were able to see the JWT token in both browsers properly. We noticed some messages referring to Github on Gitlab repos. We saw this message in the UI when trying to authenticate using the button on the commits section. Not sure if this should be expected in this PR. And also seen this message after clicking on Remove App button @jpellizzari Would you mind helping us to clarify if this is the expected behavior. If not no worries, we can to create some tickets to address these. |
While testing with the UI running from within the cluster, we are seeing an expired token error which prohibits adding an app. @jpellizzari suspects we are requesting a token with an invalid expiration value. CC @josecordaz Log message from the container:
|
According to the ADR, the Gitlab auth flow for the frontend code/experience will need to go something like this: Note that this differs from the current GitHub auth strategy. It is still OAuth, but GitLab is a bit more involved.
Acceptance Criteria:
The text was updated successfully, but these errors were encountered: