Add GitLab OAuth flow the UI #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
force-pushed
the
985-gitlab-ui-auth
branch
4 times, most recently
from
48a89ee
to
81a9355
Compare
jpellizzari
force-pushed
the
985-gitlab-ui-auth
branch
from
81a9355
to
dcf6c59
Compare
joshri
approved these changes
Nov 10, 2021
JamWils
approved these changes
Nov 15, 2021
jpellizzari
force-pushed
the
985-gitlab-ui-auth
branch
2 times, most recently
from
a02097a
to
643f707
Compare
jpellizzari
force-pushed
the
985-gitlab-ui-auth
branch
from
da14f08
to
31b222a
Compare
jpellizzari
force-pushed
the
985-gitlab-ui-auth
branch
from
31b222a
to
dc866c6
Compare
|
Added a new |
joshri
pushed a commit
that referenced
this pull request
Nov 19, 2021
* Add ParseRepoURL API method * Add repo parsing to AddApp page * Add RepoInput component * Add Gitlab OAuth routes * Add gitlab OAuth UI elements * Prevent page content from overflowing * Add expiration fallback to jwt client * Add gitlab test for jwt client * Log middleware token verification errors * Store callback state before OAuth navigation * Remove unused variables from server suite test * Add CallbackState context * Use new Git-Provider-Token header name * Fix gitlab error message * Wrap RepoInput tests in callback context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #985
Adds Gitlab token retrieval to the UI:
https://drive.google.com/file/d/1w4zGgM_V1FCn4khD0Tp5DPzCO4kreEpa/view?usp=sharing
Also adds:
RepoInputWithAuthcomponent that seeks to encapsulate the auto-detection behavior.Known limitations:
Applicationto GitLab via the UI; completing this work would conflict with the 768 new directory structure #1024 PR that is being worked onGit Provideron the config repo. Specifying conflicting providers will result in an error.Git Providerin a secret name stored on the cluster(!!!). Mixing and matching providers on the same cluster will result in errors. Again, this wasn't fixed as it would conflict with 768 new directory structure #1024.@JamWils Could you focus a review on the GitLab auth stuff
@joshri and @simon Could you check out the React stuff?