Moved middleware into server package #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce inside integration folder
josecordaz
changed the title
jpellizzari
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
I disagree with the premise of the original ticket (cc @JamWils), but the AC was to NOT have middleware accessible outside of the server packaage. That said, I don't think this should be in internal.
The middleware was split into it's own package so other HTTP server implementations could share the middleware behavior. We will need to move it back out again if we ever add a new HTTP service.
In any case, this change is fine for now as it removes another top-level pkg directory.
# Conflicts: # pkg/server/server_test.go
joshri
pushed a commit
that referenced
this pull request
Nov 4, 2021
* Moved middleware to pkg/server instead to avoid conflict with reference inside integration folder * Removed old import to internal/middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #955
What changed?
Moved middleware into server package
Why?
Improve code organization
How did you test it?
CI tests
Release notes
Documentation Changes