Clarify the description of "namespace" in the UI and CLI #1023
Conversation
| @@ -49,7 +49,7 @@ Available Commands: | |||
|
|
|||
| Flags: | |||
| -h, --help Help for gitops | |||
| --namespace string Weave GitOps runtime namespace (default "wego-system") | |||
| --namespace string The namespace scope for this operation (default "wego-system"). | |||
There was a problem hiding this comment.
This is a change I did in a branch. Trying to be super specific about what this flag does.
| --namespace string The namespace scope for this operation (default "wego-system"). | |
| --namespace string The Kubernetes namespace in which Weave GitOps objects will be stored (default "wego-system"). |
There was a problem hiding this comment.
@jpellizzari specific can be tricky... doing a get/status or remove isn't a "will be", it's "the objects are here already"
There was a problem hiding this comment.
@sympatheticmoose Not sure what you mean. We are open to suggestions on the text itself.
There was a problem hiding this comment.
I gave my suggestion already in the issue ;) I'm saying "will be stored" implies that this is always an action where I am about to store objects which don't yet exist into the given namespace. Which isn't the case for read or remove operations.
There was a problem hiding this comment.
OK I missed that. @joshri ^^
…ps/root, and the text in the README
jpellizzari
force-pushed
the
898-namespace-text
branch
from
ead4d05
to
e3b4c4e
Compare
…low down my face. I may have deleted periods that I needed? I am lost, but I hope that the tests will pass.
Closes #898
Changes the description of the namespace field in the UI (ApplicationAdd), as well as the --namespace flag in gitops/root + README.