Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits show up in UI after authentication success #1042

Merged
merged 2 commits into from Nov 5, 2021

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Nov 5, 2021

Closes #943

GitHub authorization now properly refreshes the commits table, and removes false authentication error.

authSuccess is now passed as a prop to CommitsTable, and included in the commit request useEffect dependency array!

@joshri joshri added the area/ui Issues that require front-end work label Nov 5, 2021
@joshri joshri merged commit 848396a into main Nov 5, 2021
@joshri joshri deleted the 943-refresh-commit-table branch November 5, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work
Projects
None yet
2 participants