Renaming Git Provider Token header #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
reviewed
Nov 10, 2021
pkg/server/middleware/middleware.go
Outdated
| const ( | ||
| tokenKey key = iota | ||
| GRPCAuthMetadataKey = "grpc-auth" | ||
| GitProviderTokenHeader = "X-Git-Provider-Token" |
There was a problem hiding this comment.
There was a problem hiding this comment.
sounds good, I'll remove the X- prefix
jpellizzari
approved these changes
Nov 10, 2021
ui/contexts/AppContext.tsx
Outdated
| @@ -52,7 +52,7 @@ function wrapClient<T>(client: any, tokenGetter: () => string): T { | |||
| ...options, | |||
| headers: new Headers({ | |||
| ...(options.headers || {}), | |||
| Authorization: `token ${tokenGetter()}`, | |||
| "X-Git-Provider-Token": `token ${tokenGetter()}`, | |||
There was a problem hiding this comment.
Can we make this a const as well? For computed keys in JS objects:
Suggested change
| "X-Git-Provider-Token": `token ${tokenGetter()}`, | |
| [gitProviderTokenHeader]: `token ${tokenGetter()}`, |
|
This is for this PR https://github.com/weaveworks/weave-gitops/pull/965/files#diff-142329b4654445c09cf14ebc4afba7677e064ede74cb549a81e935b414156dd2R248 and the header in there is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #971
What changed?
Why?
How did you test it?
Release notes
Documentation Changes