Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1062 - Use the correct default config branch for auto-merge #1063

Merged

Conversation

jrryjcksn
Copy link
Contributor

@jrryjcksn jrryjcksn commented Nov 10, 2021

Closes: #1062

What changed?
We now select the correct default branch before cloning an external config repository

Why?
To work correctly with repositories that use different default branches (such as old GitHub ones with master)

How did you test it?

  • Manual tests
  • New unit tests

Release notes
No

Documentation Changes
No

@jrryjcksn jrryjcksn self-assigned this Nov 10, 2021
@jrryjcksn jrryjcksn added bug Something isn't working severity/high low < medium < high < critical labels Nov 10, 2021
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@josecordaz josecordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrryjcksn jrryjcksn merged commit 1c01172 into main Nov 10, 2021
@jrryjcksn jrryjcksn deleted the 1062-use-correct-default-config-branch-for-auto-merge branch November 10, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity/high low < medium < high < critical
Projects
None yet
3 participants