Fix cluster pull request statuses #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foot
approved these changes
Nov 17, 2021
foot
reviewed
Nov 17, 2021
pkg/clusters/clusters.go
Outdated
| c.Status = "Deletion PR" | ||
| } | ||
|
|
||
| fmt.Fprintf(w, "%s\t%s", c.Name, c.Status) | ||
| fmt.Fprintf(w, "%s\t%s\t%s", c.Name, c.Status, c.PullRequest.Url) |
There was a problem hiding this comment.
🙌 , maybe only if c.status is creation/deletion PR. e.g. I guess leave it blank for "clusterFound" etc.
There was a problem hiding this comment.
Sure! 👌 Thank you Simon 🙏
joshri
pushed a commit
that referenced
this pull request
Nov 19, 2021
* Fix change PR status based on PR type * Fix lint * Return pr url * return pr url for creation and deletion only * Update tests * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: weaveworks/weave-gitops-enterprise#250
What changed?
Updated Cluster struct to get the correct PR type
Why?
To differentiate between different PR types whether it's creation or deletion
How did you test it?
Tested locally + unit tests
Release notes
Documentation Changes