Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed URL type git@ for one of the acceptance tests #1065

Merged
merged 4 commits into from Nov 15, 2021

Conversation

josecordaz
Copy link
Contributor

Closes: #1059

What changed?
Including URL type git@ in acceptance tests.

Why?
To cover those cases as well.

How did you test it?
Updated integration test

Release notes

Documentation Changes

@josecordaz josecordaz added the type/enhancement New feature or request label Nov 10, 2021
@josecordaz josecordaz marked this pull request as ready for review November 12, 2021 18:12
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josecordaz Why were integration test behaviors changed in this PR?

test/integration/server/helpers/helpers.go Show resolved Hide resolved
test/integration/server/helpers/helpers.go Show resolved Hide resolved
@josecordaz josecordaz merged commit ef05a8c into main Nov 15, 2021
@josecordaz josecordaz deleted the 1059-change-url-type-for-acceptance-test branch November 15, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitops beta install --app-config-url git@github.com:weavegitops/prod1-repo.git Fails
2 participants