Add SyncApplication Button to UI #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
force-pushed
the
1034-sync-app-button
branch
from
ae231a3
to
5599947
Compare
jpellizzari
approved these changes
Nov 17, 2021
| @@ -8,6 +8,7 @@ import { | |||
| Switch, | |||
| } from "react-router-dom"; | |||
| import { ToastContainer } from "react-toastify"; | |||
| import "react-toastify/dist/ReactToastify.css"; | |||
joshri
force-pushed
the
1034-sync-app-button
branch
from
e6b5436
to
6c0707b
Compare
joshri
added a commit
that referenced
this pull request
Nov 19, 2021
* added sync request and button with circular progress * -m starting unit tests and toastify incorporated on success * Fix act() warning in ApplicationDetail test * Cleanup ApplicationDetail test api mocking * -m Generalize withContext function to accept any Application props * fixed RepoInput test * fixed appContext in tests Co-authored-by: Joshua Israel <joshua.israel@weave.works> Co-authored-by: Jordan Pellizzari <jordan@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1034
A button handling the SyncApplication request has been added to ApplicationDetail, along with unit tests and numerous test-utils changes to facilitate mocking the API. Button is disabled while call is being made, but this state is not held on refresh.
Screen.Recording.2021-11-17.at.5.38.10.PM.mov