Add custom ssh key setup to fix actions #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it looks like Into one of our tests, even though it doesn't need the private key. 🤷 . If thats not an option you could untangle the ssh-agent and known hosts bits. |
jpellizzari
approved these changes
Nov 18, 2021
|
Hmmm, its a bit weird, looks like its stuck.. 👀 |
Yeah I was just looking at that but couldnt see why. I just restarted the tests to see if it happens again. |
foot
reviewed
Nov 18, 2021
.github/actions/setup-ssh/action.yml
Outdated
| using: "composite" | ||
| steps: | ||
| - name: Set up ssh | ||
| uses: ./.github/actions/setup-ssh |
foot
reviewed
Nov 18, 2021
Co-authored-by: Simon <footless@gmail.com>
|
Copied the wge one over to see if whitespace issues.. |
jpellizzari
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Add custom ssh key setup to fix actions * add ssh key to test.yml * Update .github/actions/setup-ssh/action.yml Co-authored-by: Simon <footless@gmail.com> * formatting? Co-authored-by: Justin Thompson <justin@weave.works> Co-authored-by: Simon <footless@gmail.com>
joshri
pushed a commit
that referenced
this pull request
Nov 19, 2021
* Add custom ssh key setup to fix actions * add ssh key to test.yml * Update .github/actions/setup-ssh/action.yml Co-authored-by: Simon <footless@gmail.com> * formatting? Co-authored-by: Justin Thompson <justin@weave.works> Co-authored-by: Simon <footless@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Copied over the ssh known_hosts fix from weaveworks/weave-gitops-enterprise#312. This fix is in response to https://github.blog/2021-09-01-improving-git-protocol-security-github/.
How did you test it?
If the pipeline passes its good.