Refactor tests to prevent nightly failures #1110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactored gitlab tests to ignore cluster-context so nightly workflow could pass.
Why?
A recent set of gitlab test additions were verifying
app deletion message
which includes the name of the cluster. This does not cause any problem in workflows other than the nightly. The cluster name for the nightly tests causes failures since the cluster-context for those clusters are different than what the existing function actually captures.How did you test it?
Ran nightly workflow on this branch