Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds back file required for consuming as a go module #1127

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Adds back file required for consuming as a go module #1127

merged 2 commits into from
Nov 23, 2021

Conversation

foot
Copy link
Contributor

@foot foot commented Nov 23, 2021 •
edited

What changed?

Puts back a file needed to build as a go module originally introduced in #765

Why?

It was probably removed as part of a make clean, so make sure to preserve that file when doing a make clean

How did you test it?

Pointing a consumer at this branch

jpellizzari
jpellizzari approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure this doesn't get removed by make clean?

@foot foot merged commit 1e77f2a into main Nov 23, 2021
@foot foot deleted the go-module-consumer-fixes branch November 23, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

Assignees
No one assigned
Labels
exclude from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@foot @jpellizzari