Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update protobuf files #1155

Merged
merged 4 commits into from
Dec 3, 2021
Merged

update protobuf files #1155

merged 4 commits into from
Dec 3, 2021

Conversation

palemtnrider
Copy link
Contributor

What changed?
Update tools.go with used protobuf plugins. Update the Makefile to use new version of buf mod update and change the googleapis to the non-beta version.

Why?
While building protobuf files from a clean environment I received a message about older version of googleapis being used. I also received a message about missing plugins and noticed some were defined in the tools.go file but not all.

How did you test it?
Manually via make proto and make proto-deps. Ran the unit-tests to ensure they still passed.

Release notes
No.

Documentation Changes
None.

Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@palemtnrider palemtnrider merged commit dd1f55a into main Dec 3, 2021
@palemtnrider palemtnrider deleted the upd-protobuf-files branch December 3, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants