Set explicit node version #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecordaz
approved these changes
Dec 2, 2021
palemtnrider
approved these changes
Dec 2, 2021
.github/workflows/release.yaml
Outdated
| @@ -21,6 +21,10 @@ jobs: | |||
| git fetch --tags -f | |||
| - name: Setup Go | |||
| uses: actions/setup-go@v2 | |||
| - name: Use Node.js ${{ matrix.node-version }} | |||
There was a problem hiding this comment.
Not certain if it matters, but looking at the file and I think this block should be before the next name: The
with:
go-version:...
Seems like it should go with the Setup Go entry
There was a problem hiding this comment.
Oh wow good catch. That would not have worked.
jpellizzari
force-pushed
the
jp-node-version-on-release
branch
from
7e8f5b9
to
cde014c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release job was using some node version other than 14.x