-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate proto related objects after renaming ConfigURL to ConfigRepo #1222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want this tested and verified from both the CLI and UI.
I tested it that way |
I see you changed the app CRD, can you verify that the resulting app CR has config_repo populated correctly. |
Can you also make sure commits and application status work correctly with the new CR in the cluster? |
This is working properly, just tested it. |
swagger json files changed because of an update on the libraries related to the swagger generator on my local environment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes:
What changed?
ConfigRepo
when coming from the UIWhy?
ConfigRepo
How did you test it?
Release notes
Documentation Changes