Adds a layer field to the profiles response #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Layers allow you to specify the order in which profiles are installed
yiannistri
approved these changes
Jan 11, 2022
| @@ -26,6 +27,7 @@ import ( | |||
| // ProfileAnnotation is the annotation that Helm charts must have to indicate | |||
| // that they provide a Profile. | |||
| const ProfileAnnotation = "weave.works/profile" | |||
| const LayerAnnotation = "weave.works/layer" | |||
There was a problem hiding this comment.
Shall we add a comment here describing how this is used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1269
What changed?
Layer field added to the profiles response
Why?
We want to show the layer in the UI
How did you test it?
manually and w/ unit tests