Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable checkpoint for all CI jobs #1289

Merged
merged 5 commits into from Jan 12, 2022
Merged

Disable checkpoint for all CI jobs #1289

merged 5 commits into from Jan 12, 2022

Conversation

rokshana-b
Copy link
Contributor

@rokshana-b rokshana-b commented Jan 11, 2022 •
edited

What changed?
Added CHECKPOINT_DISABLE env on all test jobs

Why?
To avoid interfering with the statistics that keep track of the number of downloads customers are making for Weave-GitOps

@rokshana-b rokshana-b changed the title Remove checkpoint for all CI jobs Disable checkpoint for all CI jobs Jan 11, 2022
palemtnrider
palemtnrider previously requested changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@palemtnrider palemtnrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT I think the code is easier to read if you add this override in the env:. The coverage tests in the deploy action is missing the override.

@rokshana-b
Copy link
Contributor Author

rokshana-b commented Jan 11, 2022 •
edited

NIT I think the code is easier to read if you add this override in the env:. The coverage tests in the deploy action is missing the override.

@palemtnrider So just adding the CHECKPOINT_DISABLE in the list of other envs should work, right? I'll do that then

@rokshana-b
Copy link
Contributor Author

@palemtnrider is there a way to test if the changes in this PR have the desired effect?

iahmad9
iahmad9 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@iahmad9 iahmad9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokshana-b rokshana-b dismissed palemtnrider’s stale review January 12, 2022 14:18

I've made the requested changes

@rokshana-b rokshana-b merged commit d3eb669 into main Jan 12, 2022
@rokshana-b rokshana-b deleted the disable-checkpoint-for-weave-gitops branch January 12, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iahmad9 iahmad9 iahmad9 approved these changes

@palemtnrider palemtnrider Awaiting requested review from palemtnrider

Assignees
No one assigned
Labels
exclude from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rokshana-b @palemtnrider @iahmad9