New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notifications if a new profile version is available #1317
Conversation
20cc9b3
to
7b9a124
Compare
…ification handling.
34296b9
to
fa2ec86
Compare
fa2ec86
to
f8682f6
Compare
f8682f6
to
84d1d8d
Compare
52317b2
to
41084ed
Compare
41084ed
to
5b639fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple nits- I'd wait for 2nd reviewer before merging 😄
LGTM, 2 ques
|
@Himangini Ah good questions!
I'll add some, thanks
Nope, I have not. I'm hoping someone will point me to some docs I can update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Re the documentation, I'll find out where's the best place to put it. Not a blocker for this PR :)
Closes #1143
Testing
notification-controller
and thesource-controller
Interesting.. where is my message?
Update:
Works!