Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Sorting to Data Table #1321

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Adds Sorting to Data Table #1321

merged 5 commits into from
Jan 24, 2022

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Jan 19, 2022

Step one in adding filtering to the table is getting the sorting properly implemented. Use npm run storybook to check out the component with data.

image

@joshri joshri added the area/ui Issues that require front-end work label Jan 19, 2022
jpellizzari
jpellizzari reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. How about some tests to ensure that the sorting is working?

jpellizzari
jpellizzari approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on the tests!

@joshri joshri merged commit 9eb01d8 into main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

Assignees
No one assigned
Labels
area/ui Issues that require front-end work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshri @jpellizzari