Get kube client during HTTP request #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
force-pushed
the
kube-refactoring
branch
3 times, most recently
from
c81a415
to
7ef3668
Compare
foot
reviewed
Jan 25, 2022
foot
reviewed
Jan 25, 2022
foot
reviewed
Jan 25, 2022
yiannistri
force-pushed
the
kube-refactoring
branch
from
7ef3668
to
855a651
Compare
joshri
pushed a commit
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #1092
What changed?
To get an instance of
kube.KubeaFactorywas used that was initialised during application startup with a*rest.Config. The responsibility of getting akube.Kubeinstance now lies with theKubeGetterwhich reads the*rest.Configduring an HTTP request and uses it to impersonate the call to the Kubernetes API.Why?
The end goal is to execute calls to the Kubernetes API on behalf of the authenticated user.
How did you test it?
Updated existing unit tests + manually
Release notes
Not yet, still behind a feature flag.
Documentation Changes
Not yet, still behind a feature flag.