Update profile endpoints to request a client.Client during an HTTP request
#1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
force-pushed
the
profile-endpoints
branch
from
960aff8
to
9e38e17
Compare
yiannistri
changed the title
client.Client during an HTTP request
aclevername
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
LGTM! The acceptance test is pended, worth unpending and giving it a run locally. You will have to follow steps in https://github.com/weaveworks/weave-gitops/blob/main/CONTRIBUTING.md#running-acceptance-tests. Happy to pair/help if you hit any problems
yiannistri
force-pushed
the
profile-endpoints
branch
from
9e38e17
to
bb9a8f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #1092
What changed?
Updated profile endpoints to request a
client.Clientduring an HTTP request.Why?
The end goal is to execute calls to the Kubernetes API on behalf of the authenticated user.
How did you test it?
Updated existing unit tests
Release notes
Not yet, still behind a feature flag.
Documentation Changes
Not yet, still behind a feature flag.